----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117995/ -----------------------------------------------------------
(Updated May 9, 2014, 8:26 a.m.) Review request for Plasma and David Edmundson. Changes ------- changed as suggested to use doUnlock, but this is changed to use xcb. Repository: plasma-workspace Description (updated) ------- [screenlocker] Add a unit test for KSldApp The unit test so far only tests establishGrab. This is a little bit tricky as we need a different X Client which grabs pointer or keyboard to make establishGrab fail. For that two small helper applications are included which do nothing else than connecting to X and the one grabbing keyboard the other grabbing pointer. The applications are started from the test to get the keyboard/pointer grabbed which results in ::establishGrab to return false. What this test is not yet able to test is handling the sleep between two grab attemps. As the test is using doUnlock() from KSldApp, the implementation is changed to use xcb for ungrab pointer/keyboard. With XLib the test would have needed an XSync which would have required to either add the XLib call to the test or doUnlock or implement the sync using xcb. REVIEW: 117995 Diffs (updated) ----- ksmserver/screenlocker/autotests/CMakeLists.txt ff95d9d031cdac32085e358e30b95a9e9a6fb7dc ksmserver/screenlocker/autotests/keyboardgrabber.cpp PRE-CREATION ksmserver/screenlocker/autotests/ksldtest.cpp PRE-CREATION ksmserver/screenlocker/autotests/pointergrabber.cpp PRE-CREATION ksmserver/screenlocker/ksldapp.h fafe894ee2068910f2f42584a1f30303036619da ksmserver/screenlocker/ksldapp.cpp 007eb2a7032d3f3210ce6a211ae9b4562dba1508 Diff: https://git.reviewboard.kde.org/r/117995/diff/ Testing ------- Thanks, Martin Gräßlin
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
