----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118013/ -----------------------------------------------------------
(Updated May 8, 2014, 11:31 a.m.) Status ------ This change has been marked as submitted. Review request for Plasma and David Edmundson. Repository: plasma-workspace Description ------- [screenlocker/greeter] Drop code for GraphicsSceneMousePressEvent handling It was used to ensure that the view which last got pressed on gets keyboard events. This is no longer needed, after clicking a screen the keyboard events end on the correct screen. [screenlocker] Rename configuration file and config groups It's not a screensaver anymore so not save into a config file and group which would indicate so. Also introduce a dedicated group for the options relevant only in the greeter. [screenlocker] Drop Saver config option It's not used anywhere in the code base. [screenlocker] Drop PluginsUnlock and PluginOption configuration keys Not used anywhere in the code base. [screenlocker] Drop Priority configuration key Not used in the code base. [screenlocker] Drop the Action* configuration keys Not used anywhere in the code base. [screenlocker] Drop SuspendWhenInvisible configuration key It's not used anywhere in the screenlocker. [screenlocker] Drop config option ScreenSaverEnabled * we don't have screen savers any more * it's only used if timeout is larger than 0 Thus the timeout itself is good enough. To make sure the timeout value is sane it got a min of 0. [screenlocker] Drop unused greeter.h and greeter.cpp It was from the old lock screen, no longer needed. Diffs ----- ksmserver/screenlocker/greeter/greeter.h 543efac6b4b5a28327646cebfec4e626d86ad906 ksmserver/screenlocker/greeter/greeter.cpp e2eda9f77cfece06ce30547c0c91630502e10654 ksmserver/screenlocker/greeter/greeterapp.cpp fa2e3442e911476cc2b995a343d10bba522ddca2 ksmserver/screenlocker/kcfg/kscreensaversettings.kcfg 6a1cbb0935461c8045dd847a63e31e72fb6ca007 ksmserver/screenlocker/ksldapp.cpp c678cfc33f82509776047894e46c4fbe15563d49 Diff: https://git.reviewboard.kde.org/r/118013/diff/ Testing ------- Thanks, Martin Gräßlin
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
