----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118024/#review57433 -----------------------------------------------------------
Ship it! it's ok, just small issue containments/panel/contents/ui/main.qml <https://git.reviewboard.kde.org/r/118024/#comment39958> Just put a big TODO, FIXME, whatever that explains this is a temporary solution - Marco Martin On May 6, 2014, 5:11 p.m., Eike Hein wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118024/ > ----------------------------------------------------------- > > (Updated May 6, 2014, 5:11 p.m.) > > > Review request for Plasma and Marco Martin. > > > Repository: plasma-desktop > > > Description > ------- > > Launcher menus traditionally offer an "Add to Panel" action for applications, > which spawns an Icon applet in the relevant panel containment. > > In the past, Containment::addApplet() had a QRect argument to set the initial > applet position. Launchers like Kickoff and Homerun Kicker made use of this > to try and insert the launcher icons to the left of the Task Manager widget, > by providing a rect to the left of the middle of the containment, based on > its geometry. > > The equivalent Containment::createApplet() in Frameworks 5 no longer has this > rect argument. The attached patch recreates this behavior inside the > implementation of the Panel containment instead, by testing for the plugin > name of the requested applet and inserting it before the applet at the center > of the layout, if any - otherwise it falls back to the existing behavior of > adding the applet before the last spacer or at the end of the layout. > > > Diffs > ----- > > containments/panel/contents/ui/main.qml 3dd531f > > Diff: https://git.reviewboard.kde.org/r/118024/diff/ > > > Testing > ------- > > > Thanks, > > Eike Hein > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
