----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117923/#review57054 -----------------------------------------------------------
This review has been submitted with commit 270c1c65d944654402755b9e9a8fac25a7166b39 by Sinny Kumari to branch master. - Commit Hook On May 1, 2014, 7:32 a.m., Sinny Kumari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117923/ > ----------------------------------------------------------- > > (Updated May 1, 2014, 7:32 a.m.) > > > Review request for Plasma. > > > Repository: plasma-mediacenter > > > Description > ------- > > Currently test is getting compiled along with libs. Due to this same source > was compiled multiple times. With this patch, Plasma-medacenter creates a new > plasmamediacentertest library which has default all exported symbols from > libs. Now, test can be linked with libplasmamediacentertest. > > > Diffs > ----- > > libs/CMakeLists.txt a0a0f72 > libs/mediacenter/CMakeLists.txt 2dbec83 > libs/mediacenter/test/fakemediavalidator.h 201973c > libs/mediacenter/test/fakemediavalidator.cpp 9b2feca > libs/mediacenter/test/lastfmimagefetchertest.h 6422824 > libs/mediacenter/test/lastfmimagefetchertest.cpp b0fcf6f > libs/mediacenter/test/mediacentertest.h 6997ae9 > libs/mediacenter/test/mediacentertest.cpp 96a70a9 > libs/mediacenter/test/medialibrarytest.h 718457d > libs/mediacenter/test/medialibrarytest.cpp 08af239 > libs/mediacenter/test/mediatest.h da16e59 > libs/mediacenter/test/mediatest.cpp 832fedb > libs/mediacenter/test/pmcmediatest.h 2322176 > libs/mediacenter/test/pmcmediatest.cpp 0da8dd3 > libs/mediacenter/test/singletonfactorytest.h 79e4197 > libs/mediacenter/test/singletonfactorytest.cpp 308487d > libs/mediacenter/test/testhelpers.h 9825e85 > libs/test/CMakeLists.txt PRE-CREATION > libs/test/fakemediavalidator.h PRE-CREATION > libs/test/fakemediavalidator.cpp PRE-CREATION > libs/test/lastfmimagefetchertest.h PRE-CREATION > libs/test/lastfmimagefetchertest.cpp PRE-CREATION > libs/test/mediacentertest.h PRE-CREATION > libs/test/mediacentertest.cpp PRE-CREATION > libs/test/medialibrarytest.h PRE-CREATION > libs/test/medialibrarytest.cpp PRE-CREATION > libs/test/mediatest.h PRE-CREATION > libs/test/mediatest.cpp PRE-CREATION > libs/test/pmcmediatest.h PRE-CREATION > libs/test/pmcmediatest.cpp PRE-CREATION > libs/test/singletonfactorytest.h PRE-CREATION > libs/test/singletonfactorytest.cpp PRE-CREATION > libs/test/testhelpers.h PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/117923/diff/ > > > Testing > ------- > > Application runs as expected and all unit test passed > > > Thanks, > > Sinny Kumari > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
