----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117800/#review56844 -----------------------------------------------------------
In the future, if you're doing a number of moves, you may want to generate the diff via --find-copies-harder - Vishesh Handa On April 29, 2014, 9:39 a.m., Shantanu Tushar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117800/ > ----------------------------------------------------------- > > (Updated April 29, 2014, 9:39 a.m.) > > > Review request for Plasma. > > > Repository: plasma-mediacenter > > > Description > ------- > > Doing so gives us two benefits- > 1. We no longer have to export classes just to test them > 2. We can use ORM mapped classes such as Artist, Album without extra magic > for tests > > (the diff shows deleted/new files because of the move, reviewing > CMakeLists.txt changes should be sufficient) > > > Diffs > ----- > > libs/CMakeLists.txt 59334e9 > libs/mediacenter/CMakeLists.txt 37769f6 > libs/mediacenter/lastfmimagefetcher.h 4541c66 > libs/mediacenter/media.h 2d6cc73 > libs/mediacenter/pmcimagecache.h d6d332e > libs/mediacenter/subtitleprovider.h 6f0d0f6 > libs/test/CMakeLists.txt 52ec617 > libs/test/fakemediavalidator.h > libs/test/fakemediavalidator.cpp c2fdc17 > libs/test/lastfmimagefetchertest.h > libs/test/lastfmimagefetchertest.cpp 9d06079 > libs/test/mediacentertest.h > libs/test/mediacentertest.cpp bb4c4d1 > libs/test/medialibrarytest.h > libs/test/medialibrarytest.cpp 746d5b2 > libs/test/mediatest.h > libs/test/mediatest.cpp 86ec0d0 > libs/test/pmcmediatest.h > libs/test/pmcmediatest.cpp 4bdcae6 > libs/test/singletonfactorytest.h > libs/test/singletonfactorytest.cpp b9fc987 > libs/test/testhelpers.h > > Diff: https://git.reviewboard.kde.org/r/117800/diff/ > > > Testing > ------- > > compiles, all unit tests pass > > > Thanks, > > Shantanu Tushar > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
