> On April 28, 2014, 5 p.m., Aleix Pol Gonzalez wrote: > > Does this demo really need to be installed? > > Hugo Pereira Da Costa wrote: > To be honest, I guess, no ... > Relic from debug days. (also I still uses every now and then, and right > now it exposes a 'bug' in Qt raster graphicssystem). > Same would be true of oxygen/kstyles/demo/oxygen-demo5 > > > Aleix Pol Gonzalez wrote: > But you don't need to install it for debugging, that's what I meant. It's > just a test.
@Aleix Yes, that is what I understood too, and agree with. Thinking twice, oxygen-demo5 on the other hand, I'd like to keep installed. It has some benchmarking features and can be helpfull to users. - Hugo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117773/#review56778 ----------------------------------------------------------- On April 25, 2014, 2:40 p.m., Jonathan Riddell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117773/ > ----------------------------------------------------------- > > (Updated April 25, 2014, 2:40 p.m.) > > > Review request for Plasma, Martin Gräßlin and Hugo Pereira Da Costa. > > > Repository: oxygen > > > Description > ------- > > make kwin-decoration co-installable with kdelibs4 equivalents, remove unused > kconfig_update script and rename oxygen-shadow-demo to oxygen-shadow-demo5 > kconfig upgrade script not used as KF5 apps will start with a fresh config > > > Diffs > ----- > > kwin-decoration/CMakeLists.txt ff99b256e94507b364965f3b8d4401dd07f55d9a > kwin-decoration/data/CMakeLists.txt > 7a4a2f7959b086d10dac313d02b49d97860fa057 > kwin-decoration/data/oxygen.upd 2271c35e20f139625be419b2e9166aa35f9203a6 > kwin-decoration/data/update_oxygen.pl > da5c34e0a331ada6e0ef3be20838b3392a4ef051 > kwin-decoration/demo/CMakeLists.txt > 60c30180165a879ff3b3ab9980b47da186ce7ffc > > Diff: https://git.reviewboard.kde.org/r/117773/diff/ > > > Testing > ------- > > > Thanks, > > Jonathan Riddell > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
