----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117813/#review56714 -----------------------------------------------------------
Overall +1 from me applets/systemtray/package/contents/ui/TaskDelegate.qml <https://git.reviewboard.kde.org/r/117813/#comment39564> No. applets/systemtray/plugin/host.cpp <https://git.reviewboard.kde.org/r/117813/#comment39565> This reminds me - didn't we decide at the Jan sprint that the popup (the "hidden" here?) should contain /all/ the systray plasmoids? Also sorry for hijacking the review, we could just fix it at once? applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.cpp <https://git.reviewboard.kde.org/r/117813/#comment39571> Whitespace leftover it seems applets/systemtray/plugin/tasklistmodel.h <https://git.reviewboard.kde.org/r/117813/#comment39566> remove ;) applets/systemtray/plugin/tasklistmodel.cpp <https://git.reviewboard.kde.org/r/117813/#comment39568> const QModelIndex& index -> const QModelIndex &index applets/systemtray/plugin/tasklistmodel.cpp <https://git.reviewboard.kde.org/r/117813/#comment39569> const QModelIndex& parent -> const QModelIndex &parent also Q_UNUSED(parent) to spare compiler warning applets/systemtray/plugin/tasklistmodel.cpp <https://git.reviewboard.kde.org/r/117813/#comment39577> Task* task -> Task *task applets/systemtray/plugin/tasklistmodel.cpp <https://git.reviewboard.kde.org/r/117813/#comment39578> Task* task -> Task *task - Martin Klapetek On April 28, 2014, 12:51 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117813/ > ----------------------------------------------------------- > > (Updated April 28, 2014, 12:51 a.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Port QQmlListProperty to QAbstractListModel. > QQmlListProperty only has a signal that the list has changed.This means when > used in a ListView every delegate has to be redone whenever a single item is > inserted or removed rather than just moved. > > Given TaskDelegate is not the simplest of things this has a performance gain, > most noticeably on startup. Also rather than sorting all items after an > insert items are inserted in the right place using qLowerBound. Now we have > the correct signals we can remove the compression, they won't add anything. > > > Other commits: > > Avoid constructing a QString for comparing, use QLatin1String for == > operators. > > Remove useless include > > Do not construct a map inside a lessThan function > > lessThan functions have to be fast. > Also Map -> Hash as we're not using order here. > > > Diffs > ----- > > applets/systemtray/package/contents/ui/ExpandedRepresentation.qml 2ef180b > applets/systemtray/package/contents/ui/PlasmoidItem.qml 0eb1687 > applets/systemtray/package/contents/ui/StatusNotifierItem.qml fc889a8 > applets/systemtray/package/contents/ui/TaskDelegate.qml 913d8f1 > applets/systemtray/package/contents/ui/TaskListDelegate.qml 5501e02 > applets/systemtray/plugin/CMakeLists.txt f6e23b4 > applets/systemtray/plugin/host.h 02c5bbe > applets/systemtray/plugin/host.cpp eafd0b6 > applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.cpp 2b846f2 > applets/systemtray/plugin/tasklistmodel.h PRE-CREATION > applets/systemtray/plugin/tasklistmodel.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/117813/diff/ > > > Testing > ------- > > Seems to work :) > > see branch davidedmundson/faster_systray to test > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
