----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117798/#review56651 -----------------------------------------------------------
Nice! Maybe you could keep the style file in a separate file? One day it could be useful. Also you need to modify the CMakeLists.txt file to install it too, no? - Aleix Pol Gonzalez On April 26, 2014, 7:53 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117798/ > ----------------------------------------------------------- > > (Updated April 26, 2014, 7:53 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Add a ComboBox to PlasmaComponents. > > > Diffs > ----- > > src/declarativeimports/plasmacomponents/qml/ComboBox.qml PRE-CREATION > src/declarativeimports/plasmacomponents/qml/qmldir abf7f7c > > Diff: https://git.reviewboard.kde.org/r/117798/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
