> On April 23, 2014, 7:41 a.m., Martin Gräßlin wrote: > > Is that only relevant for the legacy (XSS) locker or also for the new > > locker? I'm just wondering whether it needs to be ported to master > > Wolfgang Bauer wrote: > Yes. I just tried, and the screen locker in master does have the same > problem. > > I wasn't able yet to get powerdevil working with plasma next, but when I > call the Lock() method via DBUS while the locker is already running and still > in the grace period (I manually created a ~/.config/kscreensaverrc for that), > the password input field is missing there as well, so you cannot unlock.
I have adapted the patch to master as well: https://build.opensuse.org/package/view_file/home:wolfi323:branches:KDE:Unstable:Frameworks/plasma-workspace5/screenlocker-always-show-password-dialog-when-needed.patch?expand=0 I tested it and it fixes the problem there too. Should I create a new review request for this? There are no drastic differences to the KDE4 patch anyway. - Wolfgang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117091/#review56241 ----------------------------------------------------------- On April 22, 2014, 10:34 p.m., Wolfgang Bauer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117091/ > ----------------------------------------------------------- > > (Updated April 22, 2014, 10:34 p.m.) > > > Review request for kde-workspace, Plasma and Aaron J. Seigo. > > > Bugs: 327947 and 329076 > http://bugs.kde.org/show_bug.cgi?id=327947 > http://bugs.kde.org/show_bug.cgi?id=329076 > > > Repository: kde-workspace > > > Description > ------- > > If the screen locker is set to not require a password to unlock, it will not > show the password input field even when the powermanagement settings suspend > the system and are set to require a password after resume (when it was > already running at that point). > This locks people out of their system. > > This patch adds a signal handler for SIGUSR1 that switches the running > greeter to immediateLock mode. The locker sends that signal to make sure the > greeter shows the password input field when necessary. > > > Diffs > ----- > > ksmserver/screenlocker/greeter/greeterapp.cpp c5e2f85 > ksmserver/screenlocker/greeter/main.cpp d898734 > ksmserver/screenlocker/greeter/greeterapp.h 8b79188 > ksmserver/screenlocker/ksldapp.cpp 3dfcc9e > > Diff: https://git.reviewboard.kde.org/r/117091/diff/ > > > Testing > ------- > > Disable "Require password after" in the screen locker settings (the default), > set it to start after 1 min. (for easier testing). > Enable "Suspend session after" and set it to 2 minutes. (set the action to > "Suspend", "Hibernate", or "Lock Screen", doesn't matter) > Make sure "Lock screen on resume" is enabled in the powermanagements > "Advanced Options" (it is by default). > > After 1 minute the screen locker kicks in, and doesn't require a password. > After 2 minutes the session gets suspended, hibernated or locked, and > requires a password to resume. > > Without this patch no password dialog is shown, the user cannot resume the > session by entering the password. > > With this patch this works: there is a password input field, the session is > unlocked when the user enters the password. > > > Thanks, > > Wolfgang Bauer > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
