----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117631/#review56056 -----------------------------------------------------------
plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml <https://git.reviewboard.kde.org/r/117631/#comment39124> you don't need it (check below) plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml <https://git.reviewboard.kde.org/r/117631/#comment39126> The konsoleButton doesn't change the visibility of the konsole. The onClicked signal doesn't exist. plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml <https://git.reviewboard.kde.org/r/117631/#comment39125> replace konsoleVisible with desktop.konsoleVisible We already know that there is a property called "desktop" from view.cpp so we are already familiar with desktop.*. Introducing a new property makes it harder to understand the code. desktop.* -> its coming from view.cpp konsoleVisible -> desktop.konsoleVisible -> its coming from view.cpp - Giorgos Tsiapaliokas On April 18, 2014, 6:15 p.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117631/ > ----------------------------------------------------------- > > (Updated April 18, 2014, 6:15 p.m.) > > > Review request for Plasma. > > > Repository: plasmate > > > Description > ------- > > The konsole button should be shown only if the konsole is enabled. > There is no need to show a button which actually does nothing. > > > Diffs > ----- > > plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml c3624a5 > plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml afe6c1e > > Diff: https://git.reviewboard.kde.org/r/117631/diff/ > > > Testing > ------- > > > Thanks, > > Antonis Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
