----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117452/#review55294 -----------------------------------------------------------
Ship it! kglobalaccel/kglobalaccel_x11.cpp <https://git.reviewboard.kde.org/r/117452/#comment38511> Why don't you just delete it by hand? it's not like there's a return or anything... It looks good to me, I have no idea of what the ::syncX code is for, but I think I can trust you on that one. ;) - Aleix Pol Gonzalez On April 9, 2014, 4:13 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117452/ > ----------------------------------------------------------- > > (Updated April 9, 2014, 4:13 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > [kglobalaccel] Port away from dead #ifdef Q_WS_X11 > > * Add a configure-kglobalaccel.h which defines HAVE_X11 > * Port all Q_WS_X11 to HAVE_X11 > * Implement a replacement for qApp->syncX() > > > Diffs > ----- > > kglobalaccel/CMakeLists.txt b77f85edab091fd260fb9bddb1ddb43df445c5fe > kglobalaccel/component.cpp 72a4980a3c26140bde692d376338da03dc67086e > kglobalaccel/config-kglobalaccel.h.cmake PRE-CREATION > kglobalaccel/globalshortcutsregistry.cpp > 41a351b47a66c24f2e25d0d0d1df9c8a9b6616ef > kglobalaccel/kglobalaccel_x11.h c0e9334517e3954dde211fd5d79e59f4bb56e2bd > kglobalaccel/kglobalaccel_x11.cpp 9da8907485b55d522299200b4e5db307a73ae4e4 > > Diff: https://git.reviewboard.kde.org/r/117452/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
