----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117359/#review54948 -----------------------------------------------------------
Can you create the patch with --find-copies-harder? It will be much easier to review. - Aleix Pol Gonzalez On April 3, 2014, 3:31 p.m., Harald Sitter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117359/ > ----------------------------------------------------------- > > (Updated April 3, 2014, 3:31 p.m.) > > > Review request for Plasma and Àlex Fiestas. > > > Repository: plasma-workspace > > > Description > ------- > > import phonon KCM and phonon platform plugin > > - both ported away from deprecated classes > - the kcm additionally had a cleanup of phonon private header copies > - backendselection in the KCM was ported to a native Qt solution for > phonon4qt5 > - the platform plugin has just about all pointless features removed leading > up to what may (or may not) be a platform plugin in a future phonon5 API > - all direct ALSA handling was removed (e.g. the kded phononserver), we > prefer PulseAudio device control over anything else, and short of that > we'll expect the actual backend to provide a list of possible outputs > > > Diffs > ----- > > phonon/kcm/Messages.sh PRE-CREATION > phonon/kcm/CMakeLists.txt PRE-CREATION > CMakeLists.txt 28ad201 > phonon/CMakeLists.txt PRE-CREATION > phonon/platform_kde/phononbackend.desktop PRE-CREATION > phonon/platform_kde/phonon.notifyrc PRE-CREATION > phonon/platform_kde/kiomediastream_p.h PRE-CREATION > phonon/platform_kde/kiomediastream.cpp PRE-CREATION > phonon/platform_kde/kiomediastream.h PRE-CREATION > phonon/platform_kde/kdeplatformplugin.cpp PRE-CREATION > phonon/platform_kde/kdeplatformplugin.h PRE-CREATION > phonon/platform_kde/debug.cpp PRE-CREATION > phonon/platform_kde/debug.h PRE-CREATION > phonon/platform_kde/Messages.sh PRE-CREATION > phonon/platform_kde/CMakeLists.txt PRE-CREATION > phonon/kcm/testspeakerwidget.cpp PRE-CREATION > phonon/kcm/main.cpp PRE-CREATION > phonon/kcm/testspeakerwidget.h PRE-CREATION > phonon/kcm/main.h PRE-CREATION > phonon/kcm/listview-background.png PRE-CREATION > phonon/kcm/kcm_phonon.desktop PRE-CREATION > phonon/kcm/devicepreference.ui PRE-CREATION > phonon/kcm/devicepreference.cpp PRE-CREATION > phonon/kcm/devicepreference.h PRE-CREATION > phonon/kcm/backendselection.ui PRE-CREATION > phonon/kcm/backendselection.cpp PRE-CREATION > phonon/kcm/backendselection.h PRE-CREATION > phonon/kcm/audiosetup.ui PRE-CREATION > phonon/kcm/audiosetup.h PRE-CREATION > phonon/kcm/audiosetup.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/117359/diff/ > > > Testing > ------- > > - build & install > - kcm change device order & change backend order > > > Thanks, > > Harald Sitter > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
