----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117324/#review54943 -----------------------------------------------------------
Ship it! ksmserver/screenlocker/logind.h <https://git.reviewboard.kde.org/r/117324/#comment38340> const & on the connection ksmserver/screenlocker/logind.cpp <https://git.reviewboard.kde.org/r/117324/#comment38341> This is a blocking call to DBus. Probably not an issue given ksmserver doesn't have a UI which will freeze; especially during construction, but given you tried making the other calls async it's worth mentioning. QDbusInterface ctor is also blocking. - David Edmundson On April 2, 2014, 9:05 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117324/ > ----------------------------------------------------------- > > (Updated April 2, 2014, 9:05 a.m.) > > > Review request for Plasma, Àlex Fiestas, David Edmundson, and Kirill Elagin. > > > Bugs: 314989 > https://bugs.kde.org/show_bug.cgi?id=314989 > > > Repository: plasma-workspace > > > Description > ------- > > Add logind integration to screenlocker > > A new class LogindIntegration is added to the screenlocker. This class > listens to the Lock and Unlock signals emitted by the session object on > the logind service. > > This is integrated with the screenlocker application to start or quit the > lock when the signals are emitted. This means a locked screen is unlocked > when the Unlock signal is received from logind. Logind is a higher > authority for the screenlocker and thus follows the requests from logind. > > > Diffs > ----- > > ksmserver/screenlocker/CMakeLists.txt 55ebc6f > ksmserver/screenlocker/autotests/CMakeLists.txt PRE-CREATION > ksmserver/screenlocker/autotests/fakelogind.h PRE-CREATION > ksmserver/screenlocker/autotests/fakelogind.cpp PRE-CREATION > ksmserver/screenlocker/autotests/logindtest.cpp PRE-CREATION > ksmserver/screenlocker/ksldapp.cpp f2e5262 > ksmserver/screenlocker/logind.h PRE-CREATION > ksmserver/screenlocker/logind.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/117324/diff/ > > > Testing > ------- > > so far only tested with the unit test. Still need to restart the session. > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
