----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117312/#review54846 -----------------------------------------------------------
it's probably good having it build optionally... but disabling it konvby default looks a bit too much swiping under the carpet to me. I do have some packagekit messages, but thinks like "unable to fina a package called "data engine". This looks incorrect no matter what, i suspect there is some problem regardless of it being useful or not right now, because those messages in particular should just not be there - Marco Martin On April 1, 2014, 9:48 p.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117312/ > ----------------------------------------------------------- > > (Updated April 1, 2014, 9:48 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > imho, it doesn't make sense at this stage, and just spams people that have PK > installed... > > > Diffs > ----- > > src/plasma/CMakeLists.txt 90c020e > > Diff: https://git.reviewboard.kde.org/r/117312/diff/ > > > Testing > ------- > > builds. before the patch -DPLASMA_ENABLE_PACKAGEKIT_SUPPORT=1 definition was > added, no definition w/ patch > > > Thanks, > > Hrvoje Senjan > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
