> On March 10, 2014, 10:20 a.m., Thomas Lübking wrote: > > File Attachment: Latest kcmcompositing screenshot - kcmcompositing.png > > <https://git.reviewboard.kde.org/r/116648/#fcomment190> > > > > Scale method and vsync are backend dependent, so i'd move this below > > the two (resp. them right below the backend) > > Martin Gräßlin wrote: > I gave a try to most of the suggestions: > http://paste.opensuse.org/69069300 > > I'm not completely convinced that this is better or worse than than the > one before. > > Thomas Lübking wrote: > The left aligned checkboxes on the bottom kinda suck (at least i don't > like this in formlayouts) > -> > > Expert: [ ] Unredirect fullscreen windows // yes, techi to scare ppl. > away ;-) > Experimental: [ ] Color correction > > Martin Gräßlin wrote: > -> http://paste.opensuse.org/41108462 > > Thomas Pfeiffer wrote: > Having the "enable on startup" checkbox left-aligned totally makes sense > given that all others settings are irrelevant if compositing is turned off. > Great idea! > Oh and could it be re-labeled to "Enable Compositing", given that a) the > KCM is now officially about compositing instead of desktop effects and b) it > not only effects it on startup, because if I uncheck it and click "Apply", > compositing is turned off immediately.
it's about startup, doesn't have an effect to the running session, though the reasons for that might no longer apply. Otherwise: changing to "Enable Compositing on startup" and I'll ship it. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116648/#review52495 ----------------------------------------------------------- On March 10, 2014, 10:03 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116648/ > ----------------------------------------------------------- > > (Updated March 10, 2014, 10:03 a.m.) > > > Review request for kwin, Plasma and Antonis Tsiapaliokas. > > > Repository: kwin-compositing-kcm > > > Description > ------- > > Split into one KCM for Desktop Effects and one for Compositing > > Let's try getting the KCM a little bit less scary by properly > hiding everything the user doesn't have to care about. The prominent > desktop effects KCM only contains the list of all the effects which > can be configured and nothing else. Only exception is the disabled > check after failed GL to make this easier for the user. > > All the "advanced" settings are moved into a new KCM called > "Compositing" which is put under the hardware component in > systemsettings. This contains all advanced settings including > * whether compositing is enabled at all > * backend > * animation speeed > * scale filter > * unredirect fullscreen > * color correction > > > Diffs > ----- > > CMakeLists.txt d70672f3937fb44240c2c2d8e2a8d90c67890e2a > kcmkwineffects.desktop PRE-CREATION > kwincompositing.desktop 88ecf46b393df947d6b59ce53c924a82fc65756a > main.cpp 5c68722961be9b8a0a48f3221df7c033ba3cf946 > model.h 2efa2a9df63ee7f7ec483df004ff9530fdc0f852 > model.cpp 2b25fe04ccacf0fb719956b1b5fa0267611747e6 > qml/CompositingView.qml PRE-CREATION > qml/EffectView.qml c1a66dfa41409ba04c4cf4ddded3d95bb4bfaef2 > qml/OpenGLErrorView.qml PRE-CREATION > qml/main-compositing.qml PRE-CREATION > qml/main.qml d22dd08da529df938d99ff9d43f52f7b33a7f2d3 > > Diff: https://git.reviewboard.kde.org/r/116648/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > New advanced compositing KCM > > https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/e20bc5a1-c873-497a-b005-efb6b58da7c5__kcmcompositing.png > New effects KCM > > https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/0d6c955e-fdd2-4a84-91b4-53959f2745f5__kcmeffects.png > Effects KCM with GHNS button > > https://git.reviewboard.kde.org/media/uploaded/files/2014/03/07/f467b643-5341-4cfe-8282-eeea93bc98e5__kcmeffects.png > Latest kcmcompositing screenshot > > https://git.reviewboard.kde.org/media/uploaded/files/2014/03/10/70df036e-f3ad-455d-a323-c8f36220afd4__kcmcompositing.png > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
