----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116656/#review52383 -----------------------------------------------------------
A better solution would be move the removeFromPlaylist() method to FilterPlaylistModel (because it can map from an index in the filtered list to the actual index using methods from [1]). [1] http://qt-project.org/doc/qt-4.8/qsortfilterproxymodel.html https://projects.kde.org/projects/extragear/multimedia/plasma-mediacenter/repository/revisions/master/annotate/mediaelements/playlist/Playlist.qml#L106 - Shantanu Tushar On March 8, 2014, 9:24 a.m., Ashish Madeti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116656/ > ----------------------------------------------------------- > > (Updated March 8, 2014, 9:24 a.m.) > > > Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith > Haridasan. > > > Bugs: 331820 > http://bugs.kde.org/show_bug.cgi?id=331820 > > > Repository: plasma-mediacenter > > > Description > ------- > > When you delete a media from playlist while searching, often some other media > gets deleted. > > > Diffs > ----- > > mediaelements/playlist/PlaylistDelegate.qml 644bfd0 > > Diff: https://git.reviewboard.kde.org/r/116656/diff/ > > > Testing > ------- > > Deleted some media, when filter text was not empty. Now, the correct media is > getting deleted from the playlist. > > > Thanks, > > Ashish Madeti > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
