----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115903/#review50299 -----------------------------------------------------------
moving the GrabRole seems fine to me, but it has two small problems: * if the window removes the property the grabrole needs to be removed * if a window adds the property the grabrole needs to be added This probably needs adjustment in slotPropertyNotify kwin/effects/slidingpopups/slidingpopups.cpp <https://git.reviewboard.kde.org/r/115903/#comment35402> I think there should be a better place for this than in postPaintWindow. We only want to do this once per window and not always. - Martin Gräßlin On Feb. 20, 2014, 4:27 a.m., Sebastian Kügler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115903/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2014, 4:27 a.m.) > > > Review request for kwin and Plasma. > > > Bugs: 329991 > http://bugs.kde.org/show_bug.cgi?id=329991 > > > Repository: kde-workspace > > > Description > ------- > > slidingpopups claim windowClosedGrabRole earlier > > This seems like a more proper fix for the flickering issue in the > sliding popups effect. The problem is that slidingpopups grabs the > window in windowClosed, the fade effect checks it there, which makes > it racy. > > In my tests, I've not seen this problem with the WindowAddedGrab, but > as far as I understand, the problem may well be present there as well. > (And my proposed trick doesn't work.) I've not seen this happening in my > debugging, however. The problem there is also less visible since the > transparency curves go into the same direction, and are more "in line > with each other". > > So, proposed fix: Move the setData(WindowClosedGrabRole, ...) call from > windowClosed into windowAdded, which makes sure it's set whenever the > window goes away. > > constness for list > > > Force backgroundcontrast during slidingpopup animations > > This fixes the sliding popups losing their contrast effect when > animating, less flicker. > > In this patch, we temporarily force the contrast effect on, but only if > it hasn't been explicitely disabled. As soon as the animation stops, the > force flag is disabled again. For disappearing windows, we just set the > flag in the same way, but skip over the bookkeeping, since the window is > going to be deleted, anyway. > > > Diffs > ----- > > kwin/effects/slidingpopups/slidingpopups.h > f66e42ec4205c6a9d0375a89d0f5cc07ab163365 > kwin/effects/slidingpopups/slidingpopups.cpp > 4f0a9ea11db858b1d4233330662c3a35c5a956f6 > > Diff: https://git.reviewboard.kde.org/r/115903/diff/ > > > Testing > ------- > > No flickering observed anymore when closing the window. No side-effects > visible. With print-debugging, I verified that the WindowClosedGrabRole flag > is now picked up. > > > Thanks, > > Sebastian Kügler > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
