----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115709/#review49700 -----------------------------------------------------------
Ship it! yeah, i think that patch makes sense (altough may still jump if is the content that is loading on an already created dialog,, but corner-corner case i guess) - Marco Martin On Feb. 12, 2014, 10:43 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115709/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2014, 10:43 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Monitor the QQmlParser status from dialog > > This way we only call the expensive syncToMainItemSize once we have all > the information to accurately position the window. > > The previous approach using the timer to limit the calls doesn't work > entirely (according to my > qDebug inside the function) especially with the multiple threads to compile > things. > > This patch seems to prevent the dialog ever jumping around on load which I > sometimes saw. > > > Diffs > ----- > > src/declarativeimports/core/dialog.h 3c0df8b > src/declarativeimports/core/dialog.cpp b353caf > > Diff: https://git.reviewboard.kde.org/r/115709/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
