----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115698/#review49660 -----------------------------------------------------------
This review has been submitted with commit bada0c97ba38fc60e3262ae69b43334768c5db47 by Martin Gräßlin to branch master. - Commit Hook On Feb. 12, 2014, 1:09 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115698/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2014, 1:09 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Ensure that we can build without X11 or XCB > > * X11 is optional dependency > * XCB is optional dependency > * Qt::X11Extras is only found if both X11 and XCB are found > * switch to HAVE_X11 instead of X11_FOUND in CMakeLists > * remove/fix custom added definitions > * use #if HAVE_X11 instead of #ifdef HAVE_X11 (that is always true) > > Change is on top of review 115641 > > > Diffs > ----- > > CMakeLists.txt 7803274f34d22d2af57011cfbca0f3b888f93580 > src/declarativeimports/core/CMakeLists.txt > 2ea89b3d13324b6e43dfdf281c10a49fafe5a5e5 > src/declarativeimports/core/dialog.cpp > 81b4672f1651a98e61f874a748c2fde9b5b0f1b1 > src/declarativeimports/core/dialogshadows.cpp > 5a0ee82576e61430a1e7a330a5ad973ef75067c9 > src/plasma/CMakeLists.txt 9679cc96f82a85f75dbfc6df5790c269a821dcb9 > src/plasma/private/componentinstaller.cpp > 4f70baa9c667530f76df8edb9cee1373cfad2d4c > src/shell/CMakeLists.txt 5fbbf874a090ecc4b99b35598fe9214b914f3584 > src/shell/panelshadows.cpp d2fa85bb8644d0d610e69c26c0fad7828868d277 > > Diff: https://git.reviewboard.kde.org/r/115698/diff/ > > > Testing > ------- > > compiled with and without XLib > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
