----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115447/#review49053 -----------------------------------------------------------
Ship it! Works fine as far as the behavior is concerned. However on a personal note, I am very scared of the complexity we are bringing with this as well as the complexity we have from review #114892. Hope we can get rid of all this and do these in a much cleaner way some day. - Shantanu Tushar On Feb. 3, 2014, 3:53 p.m., Sujith Haridasan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115447/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2014, 3:53 p.m.) > > > Review request for Plasma, Shantanu Tushar and Sinny Kumari. > > > Repository: plasma-mediacenter > > > Description > ------- > > This patch should be applied on branch > remotes/origin/sujith-playlistrefactor-1instance of pmc. This patch will help > to add songs or videos to an already running instance ( or the single > instance ) of pmc. > > > Diffs > ----- > > shells/newshell/application.cpp 2d1901b > libs/mediacenter/playlistmodel.cpp 4b3cbc4 > shells/newshell/mainwindow.h 3810fa0 > shells/newshell/mainwindow.cpp b9671c3 > > Diff: https://git.reviewboard.kde.org/r/115447/diff/ > > > Testing > ------- > > 1) Launch dolphin. > 2) Start playing a song or video by clicking open with option in dolphin. > 3) Select another songs or videos from dolphin and try to open them with > plasma-mediacenter. > 4) User can see them automatically added to "Misc" playlist. > > > Thanks, > > Sujith Haridasan > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
