----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115500/#review49044 -----------------------------------------------------------
This review has been submitted with commit b97e726ae2bd98bc4ceffec6fe89880c88406104 by David Edmundson to branch master. - Commit Hook On Feb. 5, 2014, 3:44 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115500/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2014, 3:44 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Set minimumWidth of button to actually show the text > > The minimumWidth of a plasma button is based on the paintedWidth > of the text item. There is no way to work out the correct width it > should be if we set the text to elide. > (except for the hack of using a hidden fake text item) > > We should always fit contents. This won't cause any problems unless a > developer has a broken layout, at which point that should be fixed > > > Diffs > ----- > > src/declarativeimports/plasmacomponents/qml/Button.qml 03fa42c > > Diff: https://git.reviewboard.kde.org/r/115500/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
