----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115431/ -----------------------------------------------------------
Review request for Plasma. Bugs: 228902 http://bugs.kde.org/show_bug.cgi?id=228902 Repository: kde-workspace Description ------- For bug, see https://bugs.launchpad.net/ubuntu/+source/kde-workspace/+bug/1052059 and https://bugs.kde.org/show_bug.cgi?id=228902 The problem is that in original code, it always uses 23:59 to calculate the width of the text. However, in some font, AM is wider than PM, and 0 is wider than 2 and 5. That cause some fonts been cropped. Also I do a code cleanup: I delete m_isDefaultFont and expandFontToMax, which I think it is not longer useful. I do not need to distinguish whether we are using the default font. Diffs ----- plasma/generic/applets/digital-clock/clock.h f4822ec plasma/generic/applets/digital-clock/clock.cpp f26e328 Diff: https://git.reviewboard.kde.org/r/115431/diff/ Testing ------- Thanks, Yichao Zhou
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel