On Wednesday 29 January 2014, David Edmundson wrote:

> Parts I don't understand:
> 
> In compactRepresentationCheck
> when we are loading the compact version we still call
> createFullRepresentationItem(). I assumed we wanted to avoid that.

yeah, good catch, that has to be corrected.

> It would be better if we could just pass the QQmlComponent to the
> compactExpanderItem properties, and only create the items when we do
> the popup. I guess this could be done at a later date.

yep, that as well good idea

-- 
Marco Martin
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to