----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115324/ -----------------------------------------------------------
Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description ------- Plasma Mediacenter includes an extra file from taglib that only exists in taglib 1.8. However, this include is not actually used, and not using it allows Plasma Mediacenter to compile with taglib 1.7. This change is required for Plasma Active as it is using taglib 1.7 for now. Diffs ----- libs/mediacenter/mediainfoservice.cpp fb52b03 Diff: https://git.reviewboard.kde.org/r/115324/diff/ Testing ------- Compiling with both gcc and clang produce no warnings or errors. gcc generates the exact same assembly for both versions. Thanks, Matthew John Dawson
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
