----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115027/#review47447 -----------------------------------------------------------
Ship it! Can go in like this. Feel free to convert connects to compile-time syntax, but not a deal-breaker for now. plasma/generic/dataengines/share/shareservice.cpp <https://git.reviewboard.kde.org/r/115027/#comment33743> "POST" could be QStringLiteral plasma/generic/dataengines/share/shareservice.cpp <https://git.reviewboard.kde.org/r/115027/#comment33744> Which animal is this? :P plasma/generic/dataengines/share/shareservice.cpp <https://git.reviewboard.kde.org/r/115027/#comment33745> This could be a cat lashing out ;) - Sebastian Kügler On Jan. 15, 2014, 1:47 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115027/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2014, 1:47 p.m.) > > > Review request for Plasma and Vishesh Handa. > > > Repository: kde-workspace > > > Description > ------- > > Kross's KJS backend was dropped because it was unstable and the original > author suggested us to do so. > > I was trying to get this data engine to work, so I decided to port it to use > KJsEmbed directly. Only JS was being used so far so I think it's a safe > change. > > > Diffs > ----- > > CMakeLists.txt 592198b > plasma/generic/dataengines/share/CMakeLists.txt 2dcfd02 > plasma/generic/dataengines/share/shareprovider.h d17ddd9 > plasma/generic/dataengines/share/shareprovider.cpp fc528f8 > plasma/generic/dataengines/share/shareservice.h 9983292 > plasma/generic/dataengines/share/shareservice.cpp 272a467 > > Diff: https://git.reviewboard.kde.org/r/115027/diff/ > > > Testing > ------- > > I uploaded a paste with the half-ported plasmoid. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
