> On Jan. 13, 2014, 2:25 p.m., Aurélien Gâteau wrote: > > Looks sane, at least it is much closer to the original code. I didn't know > > about QSharedData::ref() (I blame the lack of doc). I am curious about the > > performance issue you mention, can you expand on it?
I doubt it is really measurable, but a QSharedPointer/QWeakPointer needs to perform two heap allocations (one for the object, one for the refcount block), whereas using QSharedData needs only one. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114932/#review47315 ----------------------------------------------------------- On Jan. 9, 2014, 8:14 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114932/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2014, 8:14 p.m.) > > > Review request for Plasma and Aurélien Gâteau. > > > Repository: plasma-framework > > > Description > ------- > > This should be slightly more efficient than the solution from e7e2eedd > which uses QWeakPointer and QSharedPointer > > > Diffs > ----- > > src/plasma/private/svg_p.h 16ed29638b6b253d1fefc220341b91f20c2d76d5 > src/plasma/svg.cpp ae97783308574c9478b6f194b8460a457a2a187e > > Diff: https://git.reviewboard.kde.org/r/114932/diff/ > > > Testing > ------- > > compiles > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
