----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114892/ -----------------------------------------------------------
(Updated Jan. 8, 2014, 6:09 a.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Changes ------- This patch fixes the following issues addressed in the previous review: a) When a file played through command line or Dolphin, the focus gets automatically to "Misc" playlist. b) Removed the config setting mentioned by shantanu and implemented it in other way. Let me know if this solution sounds ok. Repository: plasma-mediacenter Description ------- PMC can play songs from the command line or when selected from file browsers like Dolphin( using "Open With" ). PMC creates a separate playlist called "Misc" which will store the files which are tried to open from command line or so. Name given for the playlist is a temperory one ("Misc"). We can discuss here and rename it to something meaningful. I have tested this functionality and it works. Diffs (updated) ----- shells/newshell/mainwindow.cpp b2793df mediaelements/playlist/MultiplePlaylists.qml 42877f0 libs/mediacenter/multipleplaylistmodel.h 30b317b libs/mediacenter/playlistmodel.cpp 00a0cee libs/mediacenter/playlistmodel.h 3993ac3 libs/mediacenter/multipleplaylistmodel.cpp d52fa66 Diff: https://git.reviewboard.kde.org/r/114892/diff/ Testing ------- Open pmc from the command line (or from Dolphin) with multiple files to be opened: 1) PMC starts playing the songs/videos with the ones passed. With Dolphin I have tested with only one file and it worked properly. Thanks, Sujith Haridasan
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel