> On Dec. 13, 2013, 12:54 p.m., Aaron J. Seigo wrote: > > mediaelements/mediawelcome/HomeScreenFooter.qml, lines 39-41 > > <http://git.reviewboard.kde.org/r/114429/diff/1/?file=224651#file224651line39> > > > > this is incorrect; if you are using a DataEngine with an interval, then > > you let the DataEngine update you. > > > > so the Timer here should just go away and the label with the text > > should be bound to the results of the DataSource.
Yeah, I felt the same . - Heena ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114429/#review45637 ----------------------------------------------------------- On Dec. 13, 2013, 2:11 p.m., Heena Mahour wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114429/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2013, 2:11 p.m.) > > > Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith > Haridasan. > > > Repository: plasma-mediacenter > > > Description > ------- > > Replaced Text{} by Label {} > Time Data engine instead of creating Date() and hours -> less code ! > text color is predefined in Label {} > > > Diffs > ----- > > mediaelements/mediawelcome/BackendsListDelegate.qml e76af63 > mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7 > mediaelements/mediawelcome/HomeScreenText.qml 35cd20a > > Diff: http://git.reviewboard.kde.org/r/114429/diff/ > > > Testing > ------- > > yeah ,works fine ,displays days as well now. > > > Thanks, > > Heena Mahour > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
