----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114334/#review45265 -----------------------------------------------------------
Ship it! Ship It! - Marco Martin On Dec. 6, 2013, 2:25 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114334/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2013, 2:25 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Reason for this change: a QIcon might not contain the disabled pixmaps. Using > the icon effect allows to get also the disabled state for such icons. > > > Diffs > ----- > > src/declarativeimports/qtextracomponents/qiconitem.cpp 93b32d3 > > Diff: http://git.reviewboard.kde.org/r/114334/diff/ > > > Testing > ------- > > Yes, with new code for KWin (icon from window -> no disabled pixmap). > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
