-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114223/#review44898
-----------------------------------------------------------

Ship it!


Ship It!

- Shantanu Tushar


On Nov. 30, 2013, 5:07 p.m., Sujith Haridasan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114223/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2013, 5:07 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Moving popup menu to mediacenter.qml and hence making it more generic. popup 
> menu is pushed to the pagestack and hence it helps the user in keyboard 
> navigation using Esc key too.
> 
> 
> Diffs
> -----
> 
>   shells/newshell/package/contents/ui/mediacenter.qml 860b794 
>   mediaelements/popupmenu/PopupMenu.qml 6a832f7 
>   mediaelements/mediabrowser/MediaBrowser.qml ec76b99 
> 
> Diff: http://git.reviewboard.kde.org/r/114223/diff/
> 
> 
> Testing
> -------
> 
> Tested by moving the popup menu to mediacenter by launching pmc. And also 
> when pressed the Esc key it takes user to the files section of the media 
> browser.
> 
> 
> Thanks,
> 
> Sujith Haridasan
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to