----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113920/#review43907 -----------------------------------------------------------
src/shell/activity.cpp <http://git.reviewboard.kde.org/r/113920/#comment31532> QDir::separator() instead of QChar('/') here to avoid unixism. src/shell/scripting/scriptengine.cpp <http://git.reviewboard.kde.org/r/113920/#comment31534> Also here, qApp->applicationName()? src/shell/shellcorona.cpp <http://git.reviewboard.kde.org/r/113920/#comment31533> Shouldn't this rather be qApp->applicationName()? - Sebastian Kügler On Nov. 18, 2013, 5:17 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113920/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2013, 5:17 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Stop using classes from kde4support: > - KComponentData is deprecated, it will be using > QCoreApplication::applicationName() and > QCoreApplication::applicationVersion(). Of course this means that the > existing shells will have to be ported. I have no problem with doing that > port myself, if I'm told where to look into. > - Drop usage of KLocale, ported to QLocale > - Drop usage of KStandardDirs, ported to QStandardPaths > - Drop usage of KIcon, ported to QIcon > > Furthermore, there's a module in src/declarativeimports/locale that IIUC > exposes KLocale bindings to QML. A specific plan to port it should happen as > well. > > > Diffs > ----- > > CMakeLists.txt a9da457 > src/declarativeimports/core/tests/CMakeLists.txt da0dbc5 > src/declarativeimports/core/tests/sortfiltermodeltest.cpp 93ffba4 > src/declarativeimports/locale/CMakeLists.txt 6aecb84 > src/declarativeimports/qtextracomponents/tests/CMakeLists.txt 2c64b7f > src/plasma/CMakeLists.txt c227a15 > src/plasma/private/dataenginemanager.cpp 1c235e0 > src/shell/CMakeLists.txt c19dbd2 > src/shell/activity.cpp 2523397 > src/shell/scripting/appinterface.cpp 63196f9 > src/shell/scripting/scriptengine.cpp 1250c20 > src/shell/shellcorona.cpp 2519e29 > > Diff: http://git.reviewboard.kde.org/r/113920/diff/ > > > Testing > ------- > > Builds, tests pass. > > I'm unsure what else to test. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
