> On Oct. 12, 2013, 7:20 p.m., Sebastian Kügler wrote: > > plasmoidviewer/main.cpp, line 151 > > <http://git.reviewboard.kde.org/r/113207/diff/1/?file=200780#file200780line151> > > > > The [null] is confusing. What's the idea here?
the purpose of the null, is that it represents the default value of the parameter, if we don't pass any arguments > On Oct. 12, 2013, 7:20 p.m., Sebastian Kügler wrote: > > plasmoidviewer/main.cpp, line 160 > > <http://git.reviewboard.kde.org/r/113207/diff/1/?file=200780#file200780line160> > > > > This exposes a bit of ugly API in View. s_ is used as prefix for file > > statics, static methods are usually not prefixed. > > > > Feel free to address this in View. i have rename the s_createCorono to createCorona. It is ok? > On Oct. 12, 2013, 7:20 p.m., Sebastian Kügler wrote: > > plasmoidviewer/view.cpp, line 54 > > <http://git.reviewboard.kde.org/r/113207/diff/1/?file=200802#file200802line54> > > > > Do we want to set a null containment? - Antonis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113207/#review41613 ----------------------------------------------------------- On Oct. 11, 2013, 6:40 p.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113207/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2013, 6:40 p.m.) > > > Review request for Plasma. > > > Repository: plasmate > > > Description > ------- > > The plasmoidviewer2 branch contains the initial support for plasmoidviewer2. > Right now the plasmoidviewer is able to load the applet, setup the location > and the formfactor. > > > Diffs > ----- > > CMakeLists.txt 2b50b09 > plasmoidviewer/CMakeLists.txt d36fddb > plasmoidviewer/main.cpp f8a6b32 > plasmoidviewer/qmlpackages/containment/Messages.sh PRE-CREATION > plasmoidviewer/qmlpackages/containment/contents/code/LayoutManager.js > PRE-CREATION > plasmoidviewer/qmlpackages/containment/contents/config/main.xml > PRE-CREATION > plasmoidviewer/qmlpackages/containment/contents/ui/AppletAppearance.qml > PRE-CREATION > plasmoidviewer/qmlpackages/containment/contents/ui/BusyOverlay.qml > PRE-CREATION > plasmoidviewer/qmlpackages/containment/contents/ui/main.qml PRE-CREATION > plasmoidviewer/qmlpackages/containment/metadata.desktop PRE-CREATION > plasmoidviewer/qmlpackages/shell/Messages.sh PRE-CREATION > plasmoidviewer/qmlpackages/shell/contents/applet/AppletError.qml > PRE-CREATION > plasmoidviewer/qmlpackages/shell/contents/applet/CompactApplet.qml > PRE-CREATION > > plasmoidviewer/qmlpackages/shell/contents/applet/DefaultCompactRepresentation.qml > PRE-CREATION > > plasmoidviewer/qmlpackages/shell/contents/configuration/AppletConfiguration.qml > PRE-CREATION > > plasmoidviewer/qmlpackages/shell/contents/configuration/ConfigCategoryDelegate.qml > PRE-CREATION > > plasmoidviewer/qmlpackages/shell/contents/configuration/ConfigurationShortcuts.qml > PRE-CREATION > > plasmoidviewer/qmlpackages/shell/contents/configuration/MouseEventInputButton.qml > PRE-CREATION > plasmoidviewer/qmlpackages/shell/contents/defaults PRE-CREATION > plasmoidviewer/qmlpackages/shell/contents/layout.js PRE-CREATION > plasmoidviewer/qmlpackages/shell/contents/loader.qml PRE-CREATION > plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml PRE-CREATION > plasmoidviewer/qmlpackages/shell/metadata.desktop PRE-CREATION > plasmoidviewer/view.h PRE-CREATION > plasmoidviewer/view.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/113207/diff/ > > > Testing > ------- > > > Thanks, > > Antonis Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
