-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113124/
-----------------------------------------------------------

(Updated Oct. 6, 2013, 7:36 p.m.)


Review request for Plasma.


Changes
-------

Don't eat the event, but don't reset m_lastEvent either. Still works for the 
KMix case.


Summary (updated)
-----------------

MouseEventListener: Don't process event from children multiple times.


Bugs: 316546
    http://bugs.kde.org/show_bug.cgi?id=316546


Repository: kde-runtime


Description
-------

MouseEventListener: Don't process event from children multiple times.

If an event passed through multiple visually-overlapping children of
MouseEventListener, the event filter was processing the event every time.
For example, this caused problems for the KMix icon in the tray, which
would trigger volume changes three times for every mouse wheel event.

BUG:316546


Diffs (updated)
-----

  plasma/declarativeimports/qtextracomponents/mouseeventlistener.cpp 
36530e075dc52348f32032c32457a090b904c3b9 

Diff: http://git.reviewboard.kde.org/r/113124/diff/


Testing
-------

The KMix problem is gone, each mouse wheel step now changes the volume by the 
appropriate amount.


Thanks,

Nicolás Alvarez

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to