> On Sept. 23, 2013, 9:47 a.m., Sebastian Kügler wrote: > > plasma/generic/applets/icon/plugin/icon_p.h, line 31 > > <http://git.reviewboard.kde.org/r/112888/diff/1/?file=191268#file191268line31> > > > > Why Q_INVOKABLE, and not Q_PROPERTIES here? (For all three accessors). > > That would seem more declarative. > > > > This would also make the "remote" case easier, when you have to stat a > > remote file asynchronously and only know details after the network request. > > Bhushan Shah wrote: > Passing url is my main problem here.. > > Sebastian Kügler wrote: > I'd add a writable property url, which then updates all the other > properties via property bindings.
But I don't have url at the time of applet creation.. keeping it for later.. - Bhushan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112888/#review40507 ----------------------------------------------------------- On Sept. 23, 2013, 8:26 a.m., Bhushan Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112888/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2013, 8:26 a.m.) > > > Review request for Plasma, Marco Martin and Sebastian Kügler. > > > Description > ------- > > Port Icon applet to plasma2 > > Some issues.. > > -> Can be resized to 1x1. > -> Still doesn't work for folder, and external URLs. > -> Configuration dialog > > > Diffs > ----- > > plasma/generic/applets/CMakeLists.txt 4ace449 > plasma/generic/applets/icon/CMakeLists.txt 1094666 > plasma/generic/applets/icon/icon.h 45fa07c > plasma/generic/applets/icon/icon.cpp 8288850 > plasma/generic/applets/icon/package/contents/config/main.xml PRE-CREATION > plasma/generic/applets/icon/package/contents/ui/main.qml PRE-CREATION > plasma/generic/applets/icon/package/metadata.desktop PRE-CREATION > plasma/generic/applets/icon/plasma-applet-icon.desktop 8275ddd > plasma/generic/applets/icon/plugin/icon_p.h PRE-CREATION > plasma/generic/applets/icon/plugin/icon_p.cpp PRE-CREATION > plasma/generic/applets/icon/plugin/iconplugin.h PRE-CREATION > plasma/generic/applets/icon/plugin/iconplugin.cpp PRE-CREATION > plasma/generic/applets/icon/plugin/qmldir PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/112888/diff/ > > > Testing > ------- > > 1) Compiles > 2) Installs > 3) Loads > > -> Dropping application icon from KickOff - creates icon > -> Dropping files from Dolphin, both executable and normal files - creates > icon > -> Dropping folder from Dolphin - creates icon applet but neither icon nor > text because folder handling is not added yet. > > 4) Opens URL - Clicking on the icon applet opens url with kfmclient > > > File Attachments > ---------------- > > icons in panel > http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot1.png > icons as launcher > http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot2.png > files > http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot3.png > folders > http://git.reviewboard.kde.org/media/uploaded/files/2013/09/23/snapshot4.png > > > Thanks, > > Bhushan Shah > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
