> On Sept. 14, 2013, 6:22 p.m., Sebastian Kügler wrote: > > Why should the (abstract) toolbox care? What do you want to achieve?
If I understood the code of AppletInterface correctly, If we use a shell package like org.kde.desktop which specifies a toolbox in its "defaults" file AppletInterface will create a toolbox and it will add it in the view using QmlObject::createObjectFromSource. So the view will end up with a toolbox by default. But for the plasmoidviewer we don't want a toolbox and with this patch I was able to hide the toolbox. - Giorgos ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112723/#review40026 ----------------------------------------------------------- On Sept. 14, 2013, 11:38 a.m., Giorgos Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112723/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2013, 11:38 a.m.) > > > Review request for Plasma. > > > Description > ------- > > The toolBox should have a visible property in order to be > possible to do > > property Item toolBox > onToolBoxChanged: { > visible: false > } > > > Diffs > ----- > > src/scriptengines/qml/plasmoid/appletinterface.cpp 4e100d9 > > Diff: http://git.reviewboard.kde.org/r/112723/diff/ > > > Testing > ------- > > the default value of the visible property is true, > so the existing behavior doesn't change. > > > Thanks, > > Giorgos Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
