----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112445/#review39791 -----------------------------------------------------------
What happened to this? It seems to make sense... - Aleix Pol Gonzalez On Sept. 2, 2013, 8:10 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112445/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2013, 8:10 a.m.) > > > Review request for Plasma and Marco Martin. > > > Description > ------- > > Saves quite a lot of roundtrips to the XServer. Most important we > fetch the atom only once which means we don't have to refetch when > checking the property notify events. > > > Diffs > ----- > > CMakeLists.txt 84a79114bedc40d315fd110bb176855b0c0db76a > src/declarativeimports/core/CMakeLists.txt > 12c06901b51cd85f2a5e47599bf7a579e8d4d476 > src/plasma/CMakeLists.txt 1392309c4b6f433a01b1d87f9784037738bb73b3 > src/plasma/private/effectwatcher.cpp > 58ca9425ed4ef283f629a6d0c0567435b5db565d > src/plasma/private/effectwatcher_p.h > 626b1e6eb9e5209a0633ffdcdb3d186c74c99ecc > > Diff: http://git.reviewboard.kde.org/r/112445/diff/ > > > Testing > ------- > > It compiles. There's no unit test for it, so I cannot really test > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
