----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112484/#review39265 -----------------------------------------------------------
plasma/generic/dataengines/hotplug/hotplugengine.cpp <http://git.reviewboard.kde.org/r/112484/#comment28962> const plasma/generic/dataengines/hotplug/hotplugengine.cpp <http://git.reviewboard.kde.org/r/112484/#comment28958> remove plasma/generic/dataengines/hotplug/hotplugengine.cpp <http://git.reviewboard.kde.org/r/112484/#comment28961> Not your code, but I think this is wrong: QUrl::fromLocalFile() or something like that should be used. Would be nice if you fixed that as well. plasma/generic/dataengines/hotplug/hotplugengine.cpp <http://git.reviewboard.kde.org/r/112484/#comment28960> const plasma/generic/dataengines/hotplug/hotplugengine.cpp <http://git.reviewboard.kde.org/r/112484/#comment28959> remove qDebug - Sebastian Kügler On Sept. 3, 2013, 2:30 p.m., Bhushan Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112484/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2013, 2:30 p.m.) > > > Review request for Plasma and Sebastian Kügler. > > > Description > ------- > > summary > > > Diffs > ----- > > plasma/generic/dataengines/hotplug/hotplugengine.cpp 7e01928 > > Diff: http://git.reviewboard.kde.org/r/112484/diff/ > > > Testing > ------- > > Works > > > Thanks, > > Bhushan Shah > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
