> On Aug. 20, 2013, 1:47 p.m., Sebastian Kügler wrote: > > plasma/generic/applets/analog-clock/contents/ui/analogclock.qml, line 92 > > <http://git.reviewboard.kde.org/r/112150/diff/1/?file=183342#file183342line92> > > > > could this be made relative, i.e. z: secondHand.z + 1 ?
I don't think we would gain anything in this case. z on the second hand will still be the default 0 regardless of how many overlapping objects it is in front of. So this would always be the same as just z:1. The only benefit we would get is if someone explicitly sets a z-index on secondHand, but doing that would be as bad as what I've done here. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112150/#review38211 ----------------------------------------------------------- On Aug. 18, 2013, 10:28 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112150/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2013, 10:28 p.m.) > > > Review request for Plasma. > > > Description > ------- > > Diff shows my changes since viranch's code. Full code available at > davidedmundson/analog-clock > > > Git log below > -- > > Restore config for clock applet > > -- > > Remove calendar components. > Plasma will have it's own Calendar which should be shared > > -- > > Scale clock hands to fit current clock size > > -- > > Update copyright to reflect actual authors > > > -- > Port analog clock to new dataengine + config scheme > > Make the clock use the new PlasmaCore.Datasource to fetch the current > time > > -- > > Update the analog clock to run on plasma 2 > > -- > > Enable generic/applets directory > > -- > > Merge remote-tracking branch 'remotes/origin/plasma/viranch/analogclock' into > frameworks-scratch > > > Diffs > ----- > > plasma/generic/applets/analog-clock/contents/config/config.qml PRE-CREATION > plasma/generic/applets/analog-clock/contents/ui/Calendar.qml 60da3f7 > plasma/generic/applets/analog-clock/contents/ui/Cell.qml 2f0376a > plasma/generic/applets/analog-clock/contents/ui/Hand.qml eaa7a9b > plasma/generic/applets/analog-clock/contents/ui/analogclock.qml ad03f18 > plasma/generic/applets/analog-clock/contents/ui/configGeneral.qml > PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/112150/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
