On Saturday, August 03, 2013 19:34:32 Ivan Čukić wrote: > I've realized that it will be painful if I wait until everything is > finished to merge into master, and that there is not much reason for it to > be so since the master is in a playground mode anyway. > > One of the reasons for the request is that I'd like to do a few things in > parallel to the main work - cleaning up the whole plasma code, use allowed > levels of C++11 (and the 'spiffy' d-pointers as Aaron called them)...
Some comments: src/declarativeimports/hardware/: - this is solid material, Alex wants this in Solid, in fact he wants to make Solid "awesome to use from QML". Let's not introduce yet another wrapper that we have to maintain, but get it into Solid. (You know this one, as you're already merging stuff to Solid, good!) Changes to src/plasma: - needs proper apidocs, arguments, @since, etc. It would also be nice to tell about race conditions, can someone, at any given moment just set another package? What is the expected behavior then? src/platformstatus: - single line conditional also get curly braces src/utils: - A custom d-pointer implementation? This seems like overkill and makes the code a lot less readable. Just remove this and use a QScopedPointer? > *(2) The other thing I wanted to ask is can I rename org.kde.desktop to > org.kde.plasma.desktop? How about org.kde.desktopshell? That would make it clearer what it is compared to containments. This is not a full review, but some points that need addressing anyway. Cheers, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
