----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111650/#review36354 -----------------------------------------------------------
Probably worth adding a typedef for QSharedPointer<FindMatchesJob>, just like threadweaver have one for QSharedPointer<Job> CMakeLists.txt <http://git.reviewboard.kde.org/r/111650/#comment26846> Unneeded now, I pushed a similar patch this morning. src/plasma/runnermanager.cpp <http://git.reviewboard.kde.org/r/111650/#comment26847> Could use auto here, also has a redundant ; at the end of the line. - Kevin Ottens On July 23, 2013, 8:12 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111650/ > ----------------------------------------------------------- > > (Updated July 23, 2013, 8:12 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Description > ------- > > ThreadWeaver does not use Job* anymore which made the code compile fail and > some connects being wrong. > > This patch adjusts RunnerManager to also use QSharedPointer<FindMatchJob> > instead of FindMatchJob*. It > simplifies a few things as we do no longer have to call e.g. qDeleteAll and > fixes the incorrect connects. > > The patch also enables C++11 as it uses auto. > > > Diffs > ----- > > CMakeLists.txt d4d0a43 > src/plasma/private/runnerjobs.cpp a012a6c > src/plasma/private/runnerjobs_p.h cf05324 > src/plasma/runnermanager.h ebeb029 > src/plasma/runnermanager.cpp 46857f4 > > Diff: http://git.reviewboard.kde.org/r/111650/diff/ > > > Testing > ------- > > compiles, but couldn't run the unit tests (something is broken in my setup) > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
