----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111047/#review34435 -----------------------------------------------------------
It works fine, the only issue being with All Music as Sinny pointed out. Though there is one suggestion, or rather clarification-- Earlier, when the user clicks on the empty space to go back to the media, Slideshow/Media Player opens up. Now, to go back ONE LEVEL i.e. media browser , user could have pressed "ESCAPE key" for that, but now pressing ESCAPE key takes us back to the PMC homescreen. There seems no way to go back one level now, in case someone just want to Browse folders. - Akshay Ratan On June 16, 2013, 2:33 p.m., Shantanu Tushar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111047/ > ----------------------------------------------------------- > > (Updated June 16, 2013, 2:33 p.m.) > > > Review request for Plasma, Akshay Ratan and Sinny Kumari. > > > Description > ------- > > At places we assume that there always be a valid browsing backend. In many > situations this isn't true, which is exactly what this patch handles. > > > Diffs > ----- > > mediaelements/mediabrowser/MediaBrowser.qml e7aa109 > shells/newshell/package/contents/ui/mediacenter.qml d533b60 > > Diff: http://git.reviewboard.kde.org/r/111047/diff/ > > > Testing > ------- > > Tested some scenarios that I could think of. Please test few scenarios and > see if this works. > Akshay: I think the new if conditions make previousBackend necessary, please > check that your feature still works fine. > > > Thanks, > > Shantanu Tushar > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
