----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111035/#review34391 -----------------------------------------------------------
Ship it! Good to go to master, just fix this one before pushing browsingbackends/onlineservices/youtube/videodetailsmodel.h <http://git.reviewboard.kde.org/r/111035/#comment25265> even this would be const ref - Shantanu Tushar On June 15, 2013, 6:15 p.m., Sinny Kumari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111035/ > ----------------------------------------------------------- > > (Updated June 15, 2013, 6:15 p.m.) > > > Review request for Plasma. > > > Description > ------- > > Support of watching youtube video has been added in branch sinny-youtube. > Currently, it contains features: > 1. Search for youtube video > 2. Play selected video > 3. Other basic functionalities like play, pause, seek, etc currently playing > video > > > Diffs > ----- > > browsingbackends/onlineservices/CMakeLists.txt 860e2a4 > browsingbackends/onlineservices/youtube/CMakeLists.txt PRE-CREATION > browsingbackends/onlineservices/youtube/constants.h PRE-CREATION > browsingbackends/onlineservices/youtube/diskcache.h PRE-CREATION > browsingbackends/onlineservices/youtube/diskcache.cpp PRE-CREATION > browsingbackends/onlineservices/youtube/global.h PRE-CREATION > browsingbackends/onlineservices/youtube/networkaccess.h PRE-CREATION > browsingbackends/onlineservices/youtube/networkaccess.cpp PRE-CREATION > browsingbackends/onlineservices/youtube/video.h PRE-CREATION > browsingbackends/onlineservices/youtube/video.cpp PRE-CREATION > browsingbackends/onlineservices/youtube/videodefinition.h PRE-CREATION > browsingbackends/onlineservices/youtube/videodefinition.cpp PRE-CREATION > browsingbackends/onlineservices/youtube/videodetailsmodel.h PRE-CREATION > browsingbackends/onlineservices/youtube/videodetailsmodel.cpp PRE-CREATION > browsingbackends/onlineservices/youtube/youtubebackend.h PRE-CREATION > browsingbackends/onlineservices/youtube/youtubebackend.cpp PRE-CREATION > browsingbackends/onlineservices/youtube/youtubebackend.desktop PRE-CREATION > browsingbackends/onlineservices/youtube/youtubemodel.h PRE-CREATION > browsingbackends/onlineservices/youtube/youtubemodel.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/111035/diff/ > > > Testing > ------- > > Works fine > > > File Attachments > ---------------- > > > > http://git.reviewboard.kde.org/media/uploaded/files/2013/06/15/youtube_browser_2.png > > > http://git.reviewboard.kde.org/media/uploaded/files/2013/06/15/youtube_selected_video_1.png > > > http://git.reviewboard.kde.org/media/uploaded/files/2013/06/15/youtube_selected_video_play_1.png > > > Thanks, > > Sinny Kumari > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
