> On June 3, 2013, 7:13 p.m., Marco Martin wrote: > > I don't know the icon tasks plasmoid much but the patch looks fine
Ok :-) Is that a ship it? - Hrvoje ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110783/#review33686 ----------------------------------------------------------- On June 2, 2013, 4:11 p.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110783/ > ----------------------------------------------------------- > > (Updated June 2, 2013, 4:11 p.m.) > > > Review request for Plasma and Aaron J. Seigo. > > > Description > ------- > > Basically a sync of 9c2df6a32d3904856fffe7bdcfca5836883efc30 from kdelibs, > and revert of d0237179c5fc321cfb4a78514855bd6c0960ee0f from kdeplasma-addons > (icontasks where already ported to Plasma::Dialog before the commit) > > > This addresses bug 320265. > http://bugs.kde.org/show_bug.cgi?id=320265 > > > Diffs > ----- > > applets/icontasks/tooltips/tooltip.cpp b1bb8d3 > > Diff: http://git.reviewboard.kde.org/r/110783/diff/ > > > Testing > ------- > > Tested Air, oxygen, slim-glow, fake air for which i used widget/background > for tooltip (-> no "shadow" prefix -> tooltip != dialog background). The last > three are currently broken, and the patch resolves the problem. > Now Air uses shadow as it was before, and other themes are also rendered > properly. > > > Thanks, > > Hrvoje Senjan > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
