----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110684/#review33267 -----------------------------------------------------------
Ship it! Ship It! - Ivan Čukić On May 28, 2013, 3:51 a.m., Frank Reininghaus wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110684/ > ----------------------------------------------------------- > > (Updated May 28, 2013, 3:51 a.m.) > > > Review request for Plasma and Ivan Čukić. > > > Description > ------- > > The "File to activity linking plugin" performs some operations on startup > that are not guaranteed to succeed fast. Therefore, it can freeze the host > application if the user tries to open the context menu. IMHO, this is not > acceptable for a plugin that is enabled for every KDE user by default, even > those who do not use the plugin, or even do not use Activities at all. Well, > I think it is questionable if potentially blocking operations should be done > in a context menu plugin at all, but I see that there might be no other way > to do it which would be equally user-friendly way for people who do use the > plugin to link files to activities. Therefore, I propose this compromise > which makes sure that only users who consciously enable the plugin are > exposed to its potential drawbacks. > > Depends on my earlier kdelibs request > https://git.reviewboard.kde.org/r/110625/ , which did not get any objections > so far. > > From my point of view, the only alternative is a Dolphin-internal solution > that either disables the plugin unless it has been enabled explicitly or just > bans it from the context menu. This would be easier for me and require less > code changes, but I believe that the solution that I'm proposing here is > preferable because it is more transparent and gives both users and plugin > developers a choice. > > > This addresses bug 314575. > http://bugs.kde.org/show_bug.cgi?id=314575 > > > Diffs > ----- > > src/workspace/fileitemplugin/FileItemLinkingPlugin.cpp 82cb8db > > Diff: http://git.reviewboard.kde.org/r/110684/diff/ > > > Testing > ------- > > > Thanks, > > Frank Reininghaus > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
