----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110427/#review32568 -----------------------------------------------------------
This version compiles! :) Progress.. Please add a test case to tests/configloader.cpp to confirm that this works and then it may be committed. Thanks! - Aaron J. Seigo On May 15, 2013, 7:47 a.m., Michał Dutkiewicz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110427/ > ----------------------------------------------------------- > > (Updated May 15, 2013, 7:47 a.m.) > > > Review request for Plasma, Aaron J. Seigo and Marco Martin. > > > Description > ------- > > This patch aims to allow Plasma::ConfigLoader to properly load default values > of QColor that contains alpha channel (bug #318504). > Apparently constructor of QColor which takes QString as value fails to detect > and properly (QColor with alpha channel is handled properly by KConfigGroup). > > > This addresses bug 318504. > http://bugs.kde.org/show_bug.cgi?id=318504 > > > Diffs > ----- > > plasma/configloader.cpp 5c67474 > > Diff: http://git.reviewboard.kde.org/r/110427/diff/ > > > Testing > ------- > > Compiles, not tested yet. > > > Thanks, > > Michał Dutkiewicz > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
