----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110389/ -----------------------------------------------------------
Review request for Plasma and KDE Usability. Description ------- This patch adds a configure button to notifications that, when clicked, open the KNotify settings for the app that emitted the notification. This makes it much easier to turn off a notification you do not want and you have no clue where to turn it off (no novice user would know that you can actually turn these off, not even speaking of where) I asked Olivier Goffart to use his notifyrc lookup code that is licensed GPLv2 in this LGPLv2 code. I am not quite happy with it, though. Iterating over all notifyrc files, hoping to find a match, isn't exactly a good thing. I have no idea how I could do it in a different way, though. According to the specs the application name passed to the notification system is "[…] the optional name of the application sending the notification. This should be the application's formal name[…]. An example would be "FredApp E-Mail Client," rather than "fredapp-email-client." So the dataengine only gets "KDE Power Management System" and not "powerdevil", so it has to match this manually. And also, I cannot inbeforehand tell the plasmoid if a config is available at all, ie. all notifications have the wrench but if the emitting application does not offer settings (Because it is a non-native KDE app or is not configurable, like KDialog) it just does nothing (or emits a messagebox, or so, but the button is still there). For illustration how it works, see here: http://666kb.com/i/cdzg50m1huwc1k751.jpg ;-) Diffs ----- plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml df63ae6 plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml 64d9298 plasma/generic/applets/notifications/contents/ui/Notifications.qml c5be0a3 plasma/generic/dataengines/notifications/CMakeLists.txt e8d66e0 plasma/generic/dataengines/notifications/notificationaction.cpp 390cc16 plasma/generic/dataengines/notifications/notifications.operations bb5d0c6 plasma/generic/dataengines/notifications/notificationsengine.h 4644c8e plasma/generic/dataengines/notifications/notificationsengine.cpp 77f5db2 Diff: http://git.reviewboard.kde.org/r/110389/diff/ Testing ------- Works, in both the popup and history. Tested with Amarok and Powerdevil. Thanks, Kai Uwe Broulik
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
