-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109993/
-----------------------------------------------------------

(Updated April 15, 2013, 8:45 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Description
-------

This patch changes the Folder View preview popup behavior to apply sorting by 
default if the main view is unsorted. Previously, the preview popup would 
always adopt the sorting settings of the main view, including doing no sorting 
at all. The default sorting now applied instead mirrors the default sorting 
used by Folder View. If the main view is sorted in some way, however, the popup 
still follows its settings as before.

Rationale: The main view enters an unsorted mode when the user manually 
rearranges icons. Manual rearranging is not supported by preview popups and 
preview popups save no state, so unsorted mode is not useful in preview popups. 
Preview popups are more useful if they are sorted by default, since there is no 
user-set arrangement this would override. Sorted by default beats random by 
default.

I would like to apply this patch to both the KDE/4.10 and master branches.


Diffs
-----

  plasma/applets/folderview/popupview.cpp c6e881b 

Diff: http://git.reviewboard.kde.org/r/109993/diff/


Testing
-------


Thanks,

Eike Hein

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to