----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109775/#review29998 -----------------------------------------------------------
Ship it! Ship It! - Sebastian Kügler On March 28, 2013, 11:18 a.m., Maarten De Meyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109775/ > ----------------------------------------------------------- > > (Updated March 28, 2013, 11:18 a.m.) > > > Review request for Plasma, Richard Moore and Sebastian Kügler. > > > Description > ------- > > Use KToolInvocation::invokeBrowser to open links. This opens in the users > default browser instead of konqueror. > > Advantages: faster, opens in default browser > Disadvantages: only works with html (otherwise use KRun), deprecated for Qt5 > use QDesktopServices::openUrl(url) > > > Diffs > ----- > > runners/mediawiki/mediawikirunner.cpp 0b6c718 > > Diff: http://git.reviewboard.kde.org/r/109775/diff/ > > > Testing > ------- > > Tested with wikipedia using rekonq and chrome. > Articles open 'much' faster. > > > Thanks, > > Maarten De Meyer > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
