----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109709/#review29874 -----------------------------------------------------------
Ship it! which branch is this in, so i can merge it into integration? - Aaron J. Seigo On March 25, 2013, 5:46 p.m., Oliver Henshaw wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109709/ > ----------------------------------------------------------- > > (Updated March 25, 2013, 5:46 p.m.) > > > Review request for Plasma. > > > Description > ------- > > [1/2] DPMS idle timeouts are stored in seconds > > Meant that screen power-saving was probably never activated. > > BUG: 310506 > CCBUG: 304877 > > > [2/2] Suspend idle timeouts are stored in milliseconds > > Was storing in centiseconds(?) and in seconds in one place. > > Meant that suspend was activated much too soon. Suspend timeouts are > currently commented out due this problem but should work properly when > or if they are re-enabled. > > BUG: 310506 > CCBUG: 304877 > > > Diffs > ----- > > applications/settings/modules/powermanagement/contents/ui/Power.qml > c946990c8b89bf070fc830a74505b1e417850181 > > Diff: http://git.reviewboard.kde.org/r/109709/diff/ > > > Testing > ------- > > None. Don't currently have a testable plasma active VM. Only the dpms > timeouts need testing since the suspend timeouts are in a commented out > section. > > May need to test target devices in case DPMS breaks on that hardware. > > > Thanks, > > Oliver Henshaw > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
