> On Feb. 18, 2013, 1:39 a.m., Aleix Pol Gonzalez wrote: > > I don't see loosening the variables' scope as a codebase improvement. > > Mostly otherwise. > > > > Also I'd like to know how you measured this 5% of improvement, which either > > way I'm unsure if it's worth it considering that this patch makes > > everything global, now.
I think it is the worst response that I can have. Never in my entire life I saw anyone that complains about creating classes outside loops looses the scope because it is one of the most basic forms of optimizing the code. Creating classes inside loops is a great waste of resources. That why KDE4 is still bloat and slow. Is is so true that KDE3 is still alive. I think some developers should learn how to write better and fast code and avoid some commentaries like this or "This is only one more full update. Who cares??" (I saw this insanity in some place in KDE's code). This patch is one of those that I should not put in review because it is so basic, but I do because I don't want to commit anything without approval. - Raul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108992/#review27607 ----------------------------------------------------------- On Feb. 17, 2013, 12:57 p.m., Raul Fernandes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108992/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2013, 12:57 p.m.) > > > Review request for Plasma. > > > Description > ------- > > - create variables and classes outside the loops > - reserve space in QList if we know already how many items will be added > (avoid unnecessary reallocations) > - use const_iterator when possible > - remove a useless call (p->setPen(Qt::NoPen) - it will be set latter before > be used) > - avoid multiplications (x3, x2, x1 and x0) > > > Diffs > ----- > > plasma/widgets/signalplotter.cpp 8e9e294 > > Diff: http://git.reviewboard.kde.org/r/108992/diff/ > > > Testing > ------- > > I have tested with KDE 4.10 with no problems. > I have seen a improvement of about 5% in drawPlots() function, the most > expensive function in painting. > > > Thanks, > > Raul Fernandes > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
